Check uuid requirement. (#52)

* detect uuid requirement

add new function to detect uuid requirement

* Reduce generation time

New function doesn't need to be called at each generation of a menu entry

10-update_grub.conf

@@ -0,0 +1,2 @@
+[Service]
+ExecStartPost=/usr/sbin/grub-mkconfig -o /boot/grub/grub.cfg

41_snapshots-btrfs

@@ -1,65 +1,62 @@
 #! /usr/bin/env bash
 #
 #
-#################################################################################################################################################
+#########################################################################################################################################################################
-# Written by: Antynea																#
+# Written by: Antynea
-#																		#
+# BTC donation address: 1Lbvz244WA8xbpHek9W2Y12cakM6rDe5Rt
-# Purpose: Include btrfs snapshots at boot options.												#
+# Github: https://github.com/Antynea/grub-btrfs
-#																		#
+#                                                                                                                                                                       
-# What this script does:															#
+# Purpose: Include btrfs snapshots at boot options (grub-menu).
-# - Automatically List snapshots existing on root partition (btrfs).										#
+#
-# - Automatically Detect if "/boot" is in separate partition.											#
+# What this script does:
-# - Automatically Detect kernel, initramfs and intel microcode in "/boot" directory on snapshots. (For custon name, see below.)			#
+# Simple rollback using snapshots you made previously.
-# - Automatically Create corresponding "menuentry" in grub.cfg , which ensures a very easy rollback.						#
+# - Automatically List snapshots existing on root partition (btrfs).
-#																		#
+# - Automatically Detect if "/boot" is in separate partition.
-# How to use it:																#
+# - Automatically Detect kernel, initramfs and intel microcode in "/boot" directory on snapshots.
-# - Add this lines to /etc/default/grub:													#
+# - Automatically Create corresponding "menuentry" in grub.cfg , which ensures a very easy rollback.
-#																		#
+# - Automatically detect snapper and use snapper's snapshot description if available.
-# * GRUB_BTRFS_SUBMENUNAME="ArchLinux Snapshots" 												#
+#
-#	(Name menu appearing in grub.)	 													#
+# How to customize it:
-# * GRUB_BTRFS_PREFIXENTRY="Snapshot:"        		   											#
+# - Refer 41_snapshots-btrfs_config for the list of available options and their default values.
-#	(Add a name ahead your snapshots entries.) 												#
+# - Place your configurations to either /etc/grub.d/41_snapshots-btrfs_config or /etc/default/grub.
-# * GRUB_BTRFS_DISPLAY_PATH_SNAPSHOT="true"													#
+#
-#	(Show full path snapshot or only name)													#
+# - Generate grub.cfg (on Arch Linux use grub-mkconfig -o /boot/grub/grub.cfg)
-# * GRUB_BTRFS_TITLE_FORMAT="p/d/n"														#
+#
-#	(Custom title, shows/hides p"prefix" d"date" n"name" in grub-menu, separator "/", custom order available)				#
+# - grub-btrfs automatically generates snapshots entries.
-# * GRUB_BTRFS_NKERNEL=("vmlinuz-linux") 		 											#
+# - You will see it appear different entries (e.g : Snapshot: [2014-02-12 11:24:37] my snapshot name overkill)
-#	(Use only if you have custom kernel name or auto-detect failed.)									#
+#
-# * GRUB_BTRFS_NINIT=("initramfs-linux.img" "initramfs-linux-fallback.img")									#
+# Automatically update grub
-#	(Use only if you have custom initramfs name or auto-detect failed.)									#
+#  If you would like grub to automatically update when Snapper timeline snapshots and cleanups occur, simply install 10-update_grub.conf in the following locations:
-# * GRUB_BTRFS_INTEL_UCODE=("intel-ucode.img") 													#
+# - /etc/systemd/system/snapper-timeline.service.d/
-#	(Use only if you have custom intel-ucode or auto-detect failed.)									#
+# - /etc/systemd/system/snapper-cleanup.service.d/
-#																		#
+# Once the configuration files are in place, systemctl daemon-reload should be run to reload the units and make the changes active.
-# - Generate grub.cfg (on Archlinux use grub-mkconfig -o /boot/grub/grub.cfg)									#
+#
-#																		#
+# Special thanks for assistance and contributions:
-# - grub-btrfs automatically generates snapshots entries.											#
+# - My friends
-# - You will see it appear different entries (e.g : Snapshot: [2014-02-12 11:24:37] my snapshot name overkill)					#
+# - All contributors on Github
-#																		#
+#
-#																		#
+#########################################################################################################################################################################
-# To do:																	#
-#																		#													#
-#	* Display name of microcode in menuentry when available											#
-#																		#
-#################################################################################################################################################
 
 set -e
 
-#prefix="/usr"
+prefix="/usr"
-#exec_prefix="${prefix}"
+exec_prefix="/usr"
 datarootdir="/usr/share"
-#datadir="${datarootdir}"
 sysconfdir="/etc"
+grub_btrfs_config="${sysconfdir}/grub.d/41_snapshots-btrfs_config"
 
-. "${datarootdir}/grub/grub-mkconfig_lib"
 . "${sysconfdir}/default/grub"
+[[ -f "$grub_btrfs_config" ]] && . "$grub_btrfs_config"
+. "$datarootdir/grub/grub-mkconfig_lib"
 
 ######################################
 ### Variables in /etc/default/grub ###
 ######################################
-## Choice of method
+## Disable Grub-btrfs (default=active)
-choise_of_method=${GRUB_BTRFS_METHOD:-"1"}
+grub_btrfs_disable=${GRUB_BTRFS_DISABLE:-"false"}
+[[ "${grub_btrfs_disable}" == "true" ]] && exit 0
 ## Submenu name
-submenuname=${GRUB_BTRFS_SUBMENUNAME:-"ArchLinux Snapshots"}
+submenuname=${GRUB_BTRFS_SUBMENUNAME:-"Arch Linux snapshots"}
 ## Prefix entry
 prefixentry=${GRUB_BTRFS_PREFIXENTRY:-"Snapshot:"}
 ## Show full path snapshot or only name
@@ -72,6 +69,22 @@ nkernel=("${GRUB_BTRFS_NKERNEL[@]}")
 ninit=("${GRUB_BTRFS_NINIT[@]}")
 ## Microcode(s) name(s)
 microcode=("${GRUB_BTRFS_INTEL_UCODE[@]}")
+## Limit snapshots to show in the Grub menu
+limit_snap_show="${GRUB_BTRFS_LIMIT:-50}"
+## How to sort snapshots list
+snap_list_sort=${GRUB_BTRFS_SUBVOLUME_SORT:-"descending"}
+case "${snap_list_sort}" in
+    ascending)          btrfssubvolsort=("--sort=+rootid");;
+    *)                  btrfssubvolsort=("--sort=-rootid")
+esac
+## Show snapshots found during run "grub-mkconfig"
+show_snap_found=${GRUB_BTRFS_SHOW_SNAPSHOTS_FOUND:-"true"}
+## Show Total of snapshots found during run "grub-mkconfig"
+show_total_snap_found=${GRUB_BTRFS_SHOW_TOTAL_SNAPSHOTS_FOUND:-"true"}
+## Ignore specific path during run "grub-mkconfig"
+ignore_specific_path=("${GRUB_BTRFS_IGNORE_SPECIFIC_PATH[@]}")
+## snapper's config name
+snapper_config=${GRUB_BTRFS_SNAPPER_CONFIG:-"root"}
 
 ########################
 ### variables script ###
@@ -90,95 +103,220 @@ root_uuid=$(${grub_probe} "/" --target="fs_uuid" 2>/dev/null)
 ## Parameters passed to the kernel
 kernel_parameters="$GRUB_CMDLINE_LINUX $GRUB_CMDLINE_LINUX_DEFAULT"
 ## Mount point location
-gbgmp="/tmp/gbgmp"
+gbgmp=$(mktemp -d)
 ## Class for theme
 CLASS="--class snapshots --class gnu-linux --class gnu --class os"
 ## save IFS
 oldIFS=$IFS
-## boot_dir (auto-detect if /boot is separate partition or not)
+## Detect uuid requirement (lvm,btrfs...)
-boot_dir()
+check_uuid_required() {
-{
+if [ "x${GRUB_DEVICE_UUID}" = "x" ] || [ "x${GRUB_DISABLE_LINUX_UUID}" = "xtrue" ] \
-	boot_dir="$gbgmp/$snap_dir_name/boot"
+    || ! test -e "/dev/disk/by-uuid/${GRUB_DEVICE_UUID}" \
-	[[ "$root_uuid" != "$boot_uuid" ]] && boot_dir="/boot"
+    || ( test -e "${GRUB_DEVICE}" && uses_abstraction "${GRUB_DEVICE}" lvm ); then
-	echo "$boot_dir"
+  LINUX_ROOT_DEVICE=${GRUB_DEVICE}
+else
+  LINUX_ROOT_DEVICE=UUID=${GRUB_DEVICE_UUID}
+fi
 }
 
 
+######################
+### Error Handling ###
+######################
+print_error()
+{
+	local arg="$@"
+	local nothing_to_do="If you think an error has occurred , please file a bug report at \" https://github.com/Antynea/grub-btrfs \"\n# Nothing to do. Abort.\n###### - Grub-btrfs: Snapshot detection ended   - ######\n"
+	printf "# ${arg}\n# ${nothing_to_do}" >&2 ;
+	exit 0
+}
+
+test_btrfs()
+{
+	set +e
+	type btrfs >/dev/null 2>&1
+	if [[ $? -ne 0 ]]; then
+		print_error "This script only supports snapshots of the btrfs filesystem, make sure you have btrfs-progs on your system."
+	fi
+	set -e
+}
 ##############
 ### Script ###
 ##############
 
-### BEGIN auto detect ###
+
+## Create entry
+entry()	{
+echo "$@" >> "/boot/grub/grub-btrfs.cfg"
+# local arg="$@"
+# echo "${arg}" >> "/boot/grub/grub-btrfs.cfg"
+# cat << EOF >> "/boot/grub/grub-btrfs.cfg"
+# ${arg}
+# EOF
+}
 
 ## menu entries
-snapshots_entry()
+make_menu_entries()
 {
 ## \" required for snap,kernels,init,microcode with space in their name
-	echo "	submenu '"${title_menu[*]}"' {
+	entry "submenu '$title_menu' {
-		submenu '---> "${title_menu[*]}" <---' { echo }
+	submenu '---> $title_menu <---' { echo }"
-	"
 	for k in "${name_kernel[@]}"; do
+		[[ ! -f "${boot_dir}"/"${k}" ]] && continue;
+		kversion=${k#*"-"}
 		for i in "${name_initramfs[@]}"; do
+			prefix_i=${i%%"-"*}
+			suffix_i=${i#*"-"}
+         	alt_suffix_i=${i##*"-"}
+            if   [ "${kversion}" = "${suffix_i}" ];                 then i="${i}";
+            elif [ "${kversion}.img" = "${suffix_i}" ];             then i="${i}";
+            elif [ "${kversion}-fallback.img" = "${suffix_i}" ];    then i="${i}";
+            elif [ "${kversion}.gz" = "${suffix_i}" ];              then i="${i}";
+			else 	continue ;
+			fi
 			for u in "${name_microcode[@]}"; do
-			echo "\
+				if [[ -f "${boot_dir}"/"${u}" && "${i}" != "${prefix_i}-${kversion}-${alt_suffix_i}" ]] ; then
-		menuentry '"${k}" & "${i}"' ${CLASS} "\$menuentry_id_option" 'gnulinux-snapshots-$boot_uuid'{
+				entry "
-			$(save_default_entry)
+	menuentry '"${k}" & "${i}" & "${u}"' ${CLASS} "\$menuentry_id_option" 'gnulinux-snapshots-$boot_uuid'{"
-			if [ x\$feature_all_video_module = xy ]; then
+				else
-				insmod all_video
+				entry "
-			fi
+	menuentry '"${k}" & "${i}"' ${CLASS} "\$menuentry_id_option" 'gnulinux-snapshots-$boot_uuid'{"
-			set gfxpayload=keep
+				fi
-			insmod ${boot_fs}
+				entry "\
-			if [ x\$feature_platform_search_hint = xy ]; then
+		if [ x\$feature_all_video_module = xy ]; then
-				search --no-floppy --fs-uuid  --set=root ${hs_boot} ${boot_uuid}
+		insmod all_video
-			else
+		fi
-				search --no-floppy --fs-uuid  --set=root ${boot_uuid}
+		set gfxpayload=keep
-			fi
+		insmod ${boot_fs}
-			echo 'Loading Snapshot: "${snap_date_time}" "${snap_dir_name}"'
+		if [ x\$feature_platform_search_hint = xy ]; then
-			echo 'Loading Kernel: "${k}" ...'
+			search --no-floppy --fs-uuid  --set=root ${hs_boot} ${boot_uuid}
-			linux \"${boot_dir_real_path}/"${k}"\" root=UUID=${root_uuid} rw rootflags=subvol=\""${snap_dir_name}"\" ${kernel_parameters}\
+		else
-			"
+			search --no-floppy --fs-uuid  --set=root ${boot_uuid}
-			if [ -f "$(boot_dir)"/"${u}" ] ; then
+		fi
-				echo "\
+		echo 'Loading Snapshot: "${snap_date_time}" "${snap_dir_name}"'
-			echo 'Loading Microcode & Initramfs: "${u}" "${i}" ...'
+		echo 'Loading Kernel: "${k}" ...'
-			initrd \"${boot_dir_real_path}/"${u}"\" \"/"${snap_dir_name}"/boot/"${i}"\""
+		linux \"${boot_dir_root_grub}/"${k}"\" root="${LINUX_ROOT_DEVICE}" rw rootflags=subvol=\""${snap_dir_name}"\" ${kernel_parameters}"
-			else
+				if [[ -f "${boot_dir}"/"${u}" && "${i}" != "${prefix_i}-${kversion}-${alt_suffix_i}" ]] ; then
-				echo "\
+					entry "\
-			echo 'Loading Initramfs: "${i}" ...'
+		echo 'Loading Microcode & Initramfs: "${u}" "${i}" ...'
-			initrd \"${boot_dir_real_path}/"${i}"\""
+		initrd \"${boot_dir_root_grub}/"${u}"\" \"${boot_dir_root_grub}/"${i}"\""
-			fi
+				else
-		echo "		}"
+					entry "\
+		echo 'Loading Initramfs: "${i}" ...'
+		initrd \"${boot_dir_root_grub}/"${i}"\""
+				fi
+	entry "	}"
+				count_warning_menuentries=$((1+$count_warning_menuentries))
 			done
 		done
 	done
-	echo "	}"
+	entry  "}"
+}
+
+## Trim a string from leading and trailing whitespaces
+trim() {
+	local var="$*"
+	var="${var#"${var%%[![:space:]]*}"}"
+	var="${var%"${var##*[![:space:]]}"}"
+	echo -n "$var"
 }
 
 ## List of snapshots on filesystem
 snapshot_list()
 {
-	for snap in $(btrfs subvolume list -sa /); do
+	# Query info from snapper if it is installed
+	type snapper >/dev/null 2>&1
+	if [[ $? -eq 0 ]]; then
+		local snapper_ids=($(snapper -t 0 -c "$snapper_config" list | tail -n +3 | cut -d'|' -f 2))
+		local snapper_types=($(snapper -t 0 -c "$snapper_config" list | tail -n +3 | cut -d'|' -f 1))
+
+		IFS=$'\n'
+		local snapper_descriptions=($(snapper -t 0 -c "$snapper_config" list | tail -n +3 | cut -d'|' -f 7))
+	fi
+
+	IFS=$'\n'
+
+	# Parse btrfs snapshots
+	local entries=()
+	local ids=()
+	local max_entry_length=0
+	for snap in $(btrfs subvolume list -sa "${btrfssubvolsort}" /); do
 		IFS=$oldIFS
 		snap=($snap)
 		local snap_path_name=${snap[@]:13:${#snap[@]}}
+
 		# Discard deleted snapshots
 		if [ "$snap_path_name" = "DELETED" ]; then continue; fi
 		[[ ${snap_path_name%%"/"*} == "<FS_TREE>" ]] && snap_path_name=${snap_path_name#*"/"}
-		echo ${snap[@]:10:2} ${snap_path_name}
+
+		# ignore specific path during run "grub-mkconfig"
+		if [ ! -z "${ignore_specific_path}" ] ; then
+			for isp in ${ignore_specific_path[@]} ; do
+				[[ "${snap_path_name}" == "${isp}"/* ]] && continue 2;
+			done
+		fi
+
+		# detect if /boot directory exists
+		[[ ! -d "$gbgmp/$snap_path_name/boot" ]] && continue;
+
+		local id="${snap_path_name//[!0-9]}" # brutal way to get id: remove everything non-numeric
+		ids+=("$id")
+
+		local entry="${snap[@]:10:2} | ${snap_path_name}"
+		entries+=("$entry")
+
+		# Find max length of a snapshot entry, needed for pretty formatting
+		local length="${#entry}"
+		[[ "$length" -gt "$max_entry_length" ]] && max_entry_length=$length
 	done
+
+	# Find max length of a snapshot type, needed for pretty formatting
+	local max_type_length=0
+	for id in "${ids[@]}"; do
+		for j in "${!snapper_ids[@]}"; do
+			local snapper_id="${snapper_ids[$j]//[[:space:]]/}"
+			if [[ "$snapper_id" == "$id" ]]; then
+				local snapper_type=$(trim "${snapper_types[$j]}")
+				local length="${#snapper_type}"
+				[[ "$length" -gt "$max_type_length" ]] && max_type_length=$length
+			fi
+		done
+	done
+
+	for i in "${!entries[@]}"; do
+		local id="${ids[$i]}"
+		local entry="${entries[$i]}"
+		for j in "${!snapper_ids[@]}"; do
+			local snapper_id="${snapper_ids[$j]//[[:space:]]/}"
+			if [[ "$snapper_id" == "$id" ]]; then
+				local snapper_type=$(trim "${snapper_types[$j]}")
+				local snapper_description=$(trim "${snapper_descriptions[$j]}")
+				printf -v entry "%-${max_entry_length}s | %-${max_type_length}s | %s" "$entry" "$snapper_type" "$snapper_description"
+				break
+			fi
+		done
+		echo "$entry"
+	done
+
+	IFS=$oldIFS
 }
 
 ## Detect kernels in "/boot"
 detect_kernel()
 {
-	## Arch original kernel (auto-detect)
+	list_kernel=()
-	for akernel in "$(boot_dir)"/vmlinuz-* ; do 
+	# Original kernel (auto-detect)
-		list_kernel+=("$akernel")
+	for okernel in	"${boot_dir}"/vmlinuz-* \
+			"${boot_dir}"/vmlinux-* \
+			"${boot_dir}"/kernel-* ; do
+		[[ ! -f "${okernel}" ]] && continue;
+		list_kernel+=("$okernel")
 	done
 
-	## Custom name kernel in GRUB_BTRFS_NKERNEL
+	# Custom name kernel in GRUB_BTRFS_NKERNEL
 	if [ ! -z "${nkernel}" ] ; then
-		for ckernel in "${nkernel[@]}" ; do
+		for ckernel in "${boot_dir}/${nkernel[@]}" ; do
-			[[ ! -f /"$(boot_dir)"/"${ckernel}" ]] && continue;
+			[[ ! -f "${ckernel}" ]] && continue;
 			list_kernel+=("$ckernel")
 		done
 	fi
@@ -187,15 +325,21 @@ detect_kernel()
 ## Detect initramfs in "/boot"
 detect_initramfs()
 {
-	## Arch original initramfs (auto-detect)
+	list_initramfs=()
-	for ainitramfs in "$(boot_dir)"/initramfs-* ; do 
+	# Original initramfs (auto-detect)
-		list_initramfs+=("$ainitramfs")
+	for oinitramfs in	"${boot_dir}"/initrd.img-* \
+				"${boot_dir}"/initrd-*.img \
+				"${boot_dir}"/initrd-*.gz \
+				"${boot_dir}"/initramfs-*.img \
+				"${boot_dir}"/initramfs-*.gz ; do
+		[[ ! -f "${oinitramfs}" ]] && continue;
+		list_initramfs+=("$oinitramfs")
 	done
-	
+
-	## Custom name initramfs in GRUB_BTRFS_NINIT
+	# Custom name initramfs in GRUB_BTRFS_NINIT
 	if [ ! -z "$ninit" ] ; then
-		for cinitramfs in "${ninit[@]}" ; do
+		for cinitramfs in "${boot_dir}/${ninit[@]}" ; do
-			[[ ! -f /"$(boot_dir)"/"${cinitramfs}" ]] && continue;
+			[[ ! -f "${cinitramfs}" ]] && continue;
 			list_initramfs+=("$cinitramfs")
 		done
 	fi
@@ -204,92 +348,188 @@ detect_initramfs()
 ## Detect microcode in "/boot"
 detect_microcode()
 {
-	## Arch original intel microcode
+	list_ucode=()
-	for aucode in "$(boot_dir)"/intel-ucode.img ; do
+	# Original intel microcode
-		list_ucode+=("$aucode")
+	for oiucode in "${boot_dir}"/intel-ucode.img ; do
+		[[ ! -f "${oiucode}" ]] && continue;
+		list_ucode+=("$oiucode")
 	done
 
-	## Custom name microcode in GRUB_BTRFS_INTEL_UCODE
+	# Custom name microcode in GRUB_BTRFS_INTEL_UCODE
 	if [ ! -z "$microcode" ] ; then
-		for cucode in "${microcode[@]}" ; do
+		for cucode in "${boot_dir}/${microcode[@]}" ; do
-			[[ ! -f /"$(boot_dir)"/"${cucode}" ]] && continue
+			[[ ! -f "${cucode}" ]] && continue
 			list_ucode+=("$cucode")
 		done
 	fi
+	if [ -z "${list_ucode}" ]; then list_ucode=(x); fi
 }
 
 ## Show full path snapshot or only name
 path_snapshot()
 {
 	case "${path_snapshot}" in
-		true) name_snapshot=("${snap_dir_name}");;
+		true) name_snapshot=("${snap_full_name}");;
-		*) name_snapshot=("${snap_dir_name#*"/"}")
+		*) name_snapshot=("${snap_full_name#*"/"}")
 	esac
 }
 
-
 ## Title format in grub-menu
 title_format()
 {
 	case "${title_format}" in
-		p/d/n) 	title_menu=("${prefixentry}" "${snap_date_time}" "${name_snapshot}");;
+		p/n/d) 	title_menu="${prefixentry} ${name_snapshot} ${snap_date_time}";;
-		p/n/d) 	title_menu=("${prefixentry}" "${snap_dir_name}" "${snap_date_time}");;
+		p/d) 	title_menu="${prefixentry} ${snap_date_time}";;
-		p/d) 	title_menu=("${prefixentry}" "${snap_date_time}");;
+		p/n) 	title_menu="${prefixentry} ${name_snapshot}";;
-		p/n) 	title_menu=("${prefixentry}" "${snap_dir_name}");;
+		d/n) 	title_menu="${snap_date_time} ${name_snapshot}";;
-		d/n) 	title_menu=("${snap_date_time}" "${snap_dir_name}");;
+		n/d) 	title_menu="${name_snapshot} ${snap_date_time}";;
-		n/d) 	title_menu=("${snap_dir_name}" "${snap_date_time}");;
+		p) 		title_menu="${prefixentry}";;
-		p) 	title_menu=("${prefixentry}");;
+		d)		title_menu="${snap_date_time}";;
-		d)	title_menu=("${snap_date_time}");;
+		n)		title_menu="${name_snapshot}";;
-		n)	title_menu=("${snap_dir_name}");;
+		*)		title_menu="${prefixentry} ${snap_date_time} ${name_snapshot}"
-		*)	gettext_printf $"# Warning: GRUB_BTRFS_TITLE_FORMAT=${title_format}, syntax error \n" >&2
 	esac
 }
 
 ## List of kernels, initramfs and microcode in snapshots
-list_kernels_initramfs()
+boot_bounded()
 {
+	# Initialize menu entries
 	IFS=$'\n'
 	for item in $(snapshot_list); do
+		# fix: limit_snap_show=0
+		[[ ${limit_snap_show} -le 0 ]] && break;
 		IFS=$oldIFS
-		item=($item)
+		snap_full_name="$(echo "$item" | cut -d'|' -f2-)" # do not trim it to keep nice formatting
-		snap_dir_name=${item[@]:2:${#item[@]}}
+		snap_dir_name="$(echo "$item" | cut -d'|' -f2)"
-		[[ ! -d "$gbgmp/$snap_dir_name/boot" ]] && continue;
+		snap_dir_name="$(trim "$snap_dir_name")"
-		snap_date_time=${item[@]:0:2}
+		snap_date_time="$(echo "$item" | cut -d' ' -f1-2)"
-		gettext_printf $"# Found Snapshot: %s\n" "${snap_date_time} ${snap_dir_name}" >&2 ;
+		snap_date_time="$(trim "$snap_date_time")"
-		unset list_kernel
+
+		boot_dir="$gbgmp/$snap_dir_name/boot"
+		# Kernel (Original + custom kernel)
 		detect_kernel
+		if [ -z "${list_kernel}" ]; then continue; fi
 		name_kernel=("${list_kernel[@]##*"/"}")
-		# echo "kernel = ${name_kernel[*]}"
+		# Initramfs (Original + custom initramfs)
-		unset list_initramfs
 		detect_initramfs
+		if [ -z "${list_initramfs}" ]; then continue; fi
 		name_initramfs=("${list_initramfs[@]##*"/"}")
-		# echo "initramfs = ${name_initramfs[*]}"
+		# microcode (intel-ucode + custom microcode)
-		unset list_ucode
 		detect_microcode
 		name_microcode=("${list_ucode[@]##*"/"}")
-		# echo "ucode = ${name_microcode[*]}"
+		# show snapshot found during run "grub-mkconfig"
-		boot_dir_real_path="$(make_system_path_relative_to_its_root "$(boot_dir)")"
+		if [[ "${show_snap_found}" = "true" ]]; then
-		## Create menu entries
+		printf $"# Found snapshot: %s\n" "$item" >&2 ;
-		# name snpashot
+		fi
+		# Show full path snapshot or only name
 		path_snapshot
-		# title menu custom
+		# Title format in grub-menu
 		title_format
-		# echo "${title_menu[*]}"
+		# convert /boot directory to root of GRUB (e.g /boot become /)
-		snapshots_entry
+		boot_dir_root_grub="$(make_system_path_relative_to_its_root "${boot_dir}")"
+		# Make menuentries
+		make_menu_entries
+		### Limit snapshots found during run "grub-mkconfig"
+	        count_limit_snap=$((1+$count_limit_snap))
+	        [[ $count_limit_snap -ge $limit_snap_show ]] && break;
+		# Limit generation of menuentries if exceeds 250
+		# [[ $count_warning_menuentries -ge 250 ]] && break;
 	done
 	IFS=$oldIFS
 }
-### END auto detect ###
+boot_separate()
+{
+	boot_dir="/boot"
+	# convert /boot directory to root of GRUB (e.g /boot become /)
+	boot_dir_root_grub="$(make_system_path_relative_to_its_root "${boot_dir}")"
 
-### Choice of method ###
+	# Kernel (Original + custom kernel)
-if [ ${choise_of_method} = "1" ] ; then 
+	detect_kernel
-	gettext_printf "###### - Grub-btrfs: Auto-detect - ######\n" >&2 ;
+	if [ -z "${list_kernel}" ]; then print_error "Kernels not found."; fi
-	[[ ! -d $gbgmp ]] && mkdir -p $gbgmp
+	name_kernel=("${list_kernel[@]##*"/"}")
-	mount -o subvolid=0 /dev/disk/by-uuid/$root_uuid $gbgmp/
+
-	echo "submenu '${submenuname}' {"
+	# Initramfs (Original + custom initramfs)
-	list_kernels_initramfs ;
+	detect_initramfs
-	echo "}"
+	if [ -z "${list_initramfs}" ]; then print_error "Initramfs not found."; fi
-	umount $gbgmp
+	name_initramfs=("${list_initramfs[@]##*"/"}")
-	gettext_printf "###### - Grub-btrfs: Auto-detect - ######\n" >&2 ;
+
+	# microcode (auto-detect + custom microcode)
+	detect_microcode
+	name_microcode=("${list_ucode[@]##*"/"}")
+
+	# Initialize menu entries
+	IFS=$'\n'
+	for item in $(snapshot_list); do
+		# fix: limit_snap_show=0
+		[[ ${limit_snap_show} -le 0 ]] && break;
+		IFS=$oldIFS
+		snap_full_name="$(echo "$item" | cut -d'|' -f2-)" # do not trim it to keep nice formatting
+		snap_dir_name="$(echo "$item" | cut -d'|' -f2)"
+		snap_dir_name="$(trim "$snap_dir_name")"
+		snap_date_time="$(echo "$item" | cut -d' ' -f1-2)"
+		snap_date_time="$(trim "$snap_date_time")"
+		# show snapshot found during run "grub-mkconfig"
+		if [[ "${show_snap_found}" = "true" ]]; then
+		printf $"# Found snapshot: %s\n" "$item" >&2 ;
+		fi
+		# Show full path snapshot or only name
+		path_snapshot
+		# Title format in grub-menu
+		title_format
+		# Make menuentries
+		make_menu_entries
+		# Limit snapshots found during run "grub-mkconfig"
+		count_limit_snap=$((1+$count_limit_snap))
+	        [[ $count_limit_snap -ge $limit_snap_show ]] && break;
+		# Limit generation of menuentries if exceeds 250
+		# [[ $count_warning_menuentries -ge 250 ]] && break;
+	done
+	IFS=$oldIFS
+}
+
+### Start ###
+printf "###### - Grub-btrfs: Snapshot detection started - ######\n" >&2 ;
+# if btrfs prog isn't installed, exit
+test_btrfs
+# Delete existing config
+#rm -f --preserve-root "/boot/grub/grub-btrfs.cfg"
+> "/boot/grub/grub-btrfs.cfg"
+# Create mount point then mounting
+[[ ! -d $gbgmp ]] && mkdir -p $gbgmp
+mount -o subvolid=5 /dev/disk/by-uuid/$root_uuid $gbgmp/
+# Count menuentries
+count_warning_menuentries=0
+# Count snapshots
+count_limit_snap=0
+# detect uuid requirement
+check_uuid_required
+# Detects if /boot is a separate partition
+if [[ "$root_uuid" != "$boot_uuid" ]]; then
+	printf "# Info: Separate boot partition detected \n" >&2 ;
+	boot_separate
+	else
+	printf "# Info: Separate boot partition not detected \n" >&2 ;
+	boot_bounded
 fi
-### End choice of method ###
+# unmounting mount point
+umount $gbgmp
+# Show warn, menuentries exceeds 250 entries
+[[ $count_warning_menuentries -ge 250 ]] && printf "# Generated ${count_warning_menuentries} total GRUB entries. You might experience issues loading snapshots menu in GRUB.\n" >&2 ;
+# printf "# menuentries = $count_warning_menuentries \n" >&2 ;
+# Show total found snapshots
+if [[ "${show_total_snap_found}" = "true" && ! -z "${count_limit_snap}" && "${count_limit_snap}" != "0" ]]; then
+	printf "# Found ${count_limit_snap} snapshot(s)\n" >&2 ;
+fi
+# if no snapshot found, exit
+if [[ "${count_limit_snap}" = "0" || -z "${count_limit_snap}" ]]; then
+	print_error "No snapshots found."
+fi
+root_grub="$(make_system_path_relative_to_its_root /boot/grub)"
+# Make a submenu in GRUB (grub.cfg)
+cat << EOF
+submenu '${submenuname}' {
+	configfile "${root_grub}/grub-btrfs.cfg"
+}
+EOF
+printf "###### - Grub-btrfs: Snapshot detection ended   - ######\n" >&2 ;
+### End ###

41_snapshots-btrfs_config

@@ -0,0 +1,16 @@
+#!/usr/bin/env bash
+
+# GRUB_BTRFS_SUBMENUNAME="Arch Linux snapshots"                              # Name appearing in the Grub menu
+# GRUB_BTRFS_PREFIXENTRY="Snapshot:"                                         # Add a name ahead your snapshots entries in the Grub menu
+# GRUB_BTRFS_DISPLAY_PATH_SNAPSHOT="true"                                    # Show full path snapshot or only name in the Grub menu
+# GRUB_BTRFS_TITLE_FORMAT="p/d/n"                                            # Custom title, shows/hides p"prefix" d"date" n"name" in the Grub menu, separator "/", custom order available
+# GRUB_BTRFS_LIMIT="50"                                                      # Limit the number of snapshots populated in the GRUB menu
+# GRUB_BTRFS_SUBVOLUME_SORT="descending"                                     # Sort the found subvolumes by newest first ("descending") or oldest first ("ascending") and show $GRUB_BTRFS_LIMIT first entries.
+# GRUB_BTRFS_SHOW_SNAPSHOTS_FOUND="true"                                     # Show snapshots found during run "grub-mkconfig"
+# GRUB_BTRFS_SHOW_TOTAL_SNAPSHOTS_FOUND="true"                               # Show Total of snapshots found during run "grub-mkconfig"
+# GRUB_BTRFS_NKERNEL=("vmlinuz-linux")                                       # Use only if you have custom kernel name
+# GRUB_BTRFS_NINIT=("initramfs-linux.img" "initramfs-linux-fallback.img")    # Use only if you have custom initramfs name
+# GRUB_BTRFS_INTEL_UCODE=("intel-ucode.img")                                 # Use only if you have custom intel-ucode
+# GRUB_BTRFS_IGNORE_SPECIFIC_PATH=("var/lib/docker")                         # Ignore specific path during run "grub-mkconfig"
+# GRUB_BTRFS_SNAPPER_CONFIG="root"                                           # Snapper's config name to use
+# GRUB_BTRFS_DISABLE="false"                                                 # Disable Grub-btrfs

README.md

@@ -1,15 +1,15 @@
 [![GitHub release](https://img.shields.io/github/release/Antynea/grub-btrfs.svg)](https://github.com/Antynea/grub-btrfs)
   
-### grub-btrfs
+## grub-btrfs
 
-
+This is a version 3.xx of grub-btrfs
-This is a version 1.xx of grub-btrfs
+##### BTC donation address: 1Lbvz244WA8xbpHek9W2Y12cakM6rDe5Rt
-
+##
-#### Description
+### Description
 
 grub-btrfs, Include btrfs snapshots at boot options. (grub menu)
-
+##
-#### What does grub-btrfs v1.xx do :
+### What does grub-btrfs v3.xx do :
 
 Simple rollback using snapshots you made previously.
 
@@ -17,16 +17,18 @@ Simple rollback using snapshots you made previously.
 
 * Automatically Detect if "/boot" is in separate partition.
 
-* Automatically Detect kernel, initramfs and intel microcode in "/boot" directory on snapshots. (For custon name, see below.)
+* Automatically Detect kernel, initramfs and intel microcode in "/boot" directory on snapshots.
 
 * Automatically Create corresponding "menuentry" in grub.cfg , which ensures a very easy rollback.
 
+* Automatically detect snapper and use snapper's snapshot description if available.
+##
+### How to customize it:
 
-#### How to use it:
+You have the possibility to modify many parameters.
-
 Add this lines to /etc/default/grub:
 
-* GRUB_BTRFS_SUBMENUNAME="ArchLinux Snapshots"
+* GRUB_BTRFS_SUBMENUNAME="Arch Linux Snapshots"
 
 	(Name menu appearing in grub.)
 
@@ -36,38 +38,82 @@ Add this lines to /etc/default/grub:
 	
 * GRUB_BTRFS_DISPLAY_PATH_SNAPSHOT="true"
 	
-	(Show full path snapshot or only name)
+	(Show full path snapshot or only name, weird reaction with snapper)
 	
 * GRUB_BTRFS_TITLE_FORMAT="p/d/n"
 
  	(Custom title, shows/hides p"prefix" d"date" n"name" in grub-menu, separator "/", custom order available)
 
-* GRUB_BTRFS_NKERNEL=("vmlinuz-linux")
+* GRUB_BTRFS_NKERNEL=("kernel-custom")
 
-	(Use only if you have custom kernel name or auto-detect failed.)
+	(Use it only if you have a custom kernel name)
 
-* GRUB_BTRFS_NINIT=("initramfs-linux.img" "initramfs-linux-fallback.img")
+* GRUB_BTRFS_NINIT=("initramfs-custom.img" "initrd.img-custom")
 
-	(Use only if you have custom initramfs name or auto-detect failed.)
+	(Use it only if you have a custom initramfs name)
 
 * GRUB_BTRFS_INTEL_UCODE=("intel-ucode.img")
 
-	(Use only if you have custom intel-ucode or auto-detect failed.)
+	(Use it only if you have custom intel-ucode)
+
+* GRUB_BTRFS_LIMIT="50"
+
+	(Limit the number of snapshots populated in the GRUB menu.)
+
+* GRUB_BTRFS_SUBVOLUME_SORT="descending"
+
+	(Sort the found subvolumes by newest first ("descending") or oldest first ("ascending"). 
+	If "ascending" is chosen then the $GRUB_BTRFS_LIMIT oldest
+	subvolumes will populate the menu.)
+
+* GRUB_BTRFS_SHOW_SNAPSHOTS_FOUND="true"
+	
+	(Show snapshots found during run "grub-mkconfig") 
+	
+* GRUB_BTRFS_SHOW_TOTAL_SNAPSHOTS_FOUND="true"
+	
+	(Show Total number of snapshots found during run "grub-mkconfig")
+
+* GRUB_BTRFS_IGNORE_SPECIFIC_PATH=("var/lib/docker")
+
+	(Ignore specific path during run "grub-mkconfig")
+
+* GRUB_BTRFS_SNAPPER_CONFIG="root"													
+
+	(Snapper's config name to use)
+
+* GRUB_BTRFS_DISABLE="true"
+
+	(Disable grub-btrfs)
 
 
-
+Generate grub.cfg (on Arch linux use grub-mkconfig -o /boot/grub/grub.cfg )
-Generate grub.cfg (on Archlinux use grub-mkconfig -o /boot/grub/grub.cfg )
 
 grub-btrfs automatically generates snapshots entries.
 
-You will see it appear differents entries (e.g : Snapshot: [2014-02-12 11:24:37] my snapshot name overkill )
+You will see it appear differents entries (e.g : Snapshot: 2018-01-03 15:08:41  @test1 )
+##
+### Automatically update grub
 
+If you would like grub to automatically update when Snapper timeline snapshots and cleanups occur, simply install `10-update_grub.conf` in the following locations:
 
-#### TO DO
+- `/etc/systemd/system/snapper-timeline.service.d/`
+- `/etc/systemd/system/snapper-cleanup.service.d/`
 
-* Display name of microcode in menuentry when available
+Once the configuration files are in place, `systemctl daemon-reload` should be run to reload the units and make the changes active.
 
-
+##
-
+### Discussion
-## discussion
 Pour les francophones : https://forums.archlinux.fr/viewtopic.php?f=18&t=17177
+##
+### Special thanks for assistance and contributions
+
+* [maximbaz](https://github.com/maximbaz)
+* [crossroads1112](https://github.com/crossroads1112)
+* [penetal](https://github.com/penetal)
+* [wesbarnett](https://github.com/wesbarnett)
+* [Psykar](https://github.com/Psykar)
+* [anyc](https://github.com/anyc)
+* [daftaupe](https://github.com/daftaupe)
+* [N-Parsons](https://github.com/N-Parsons)
+##